["Anders Broman \(AL/EAB\)" <anders.broman@xxxxxxxxxxxx>]

Hi,
Couldn't the get_short_manu/get_long_manu constructs be replaced by
A const value_string 
static const value_string foo_vals[] = {
  {   1, "Sequential Circuits" },
	:
  { 0, NULL }
};

and a
proto_tree_add_item()or roto_tree_add_uint()
And a hf var 
Of
	{ &hf_foo,
      { "Manufacturer", "rtpmidi.Manufacturer",
        FT_UINT32, BASE_DEC, VALS(foo_vals), 0,
        "Manufacturer", HFILL }},
  
BR
Anders

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Tobias Erichsen
Sent: den 10 oktober 2006 10:36
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] RTP-MIDI

Hi again,

I have done the changes I described earlier.  Attached in the archive you find the newest source-code version of the RTP-MIDI dissector- plugin...

I would appreciate it much, if someone could check whether this compiles & works on Linux as well...

Best regards,
Tobias

> -----Ursprüngliche Nachricht-----
> Von: wireshark-dev-bounces@xxxxxxxxxxxxx
> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] Im Auftrag von Anders 
> Broman
> Gesendet: Dienstag, 10. Oktober 2006 07:16
> An: Developer support list for Wireshark
> Betreff: Re: [Wireshark-dev] RTP-MIDI
> 
> Hi,
> At a quick glance you need to change the C++ style comments // To /* 
> */ as all compilers do not like them.
> Best regards
> Anders
> 
> -----Ursprungligt meddelande-----
> Från: wireshark-dev-bounces@xxxxxxxxxxxxx
> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Tobias Erichsen
> Skickat: den 8 oktober 2006 19:55
> Till: Developer support list for Wireshark
> Ämne: Re: [Wireshark-dev] RTP-MIDI
> 
> Well - here we go...
> 
> Attached you will find two files:
> 
> rtpmidi.zip -> the source of the rtp-midi plugin capture.zip
> -> an archive which contains two captures of rtp-midi-data
> 
> The specification that is the basis for this dissector is:
> http://www.cs.berkeley.edu/~lazzaro/sa/pubs/txt/current-rtp-midi.txt
> 
> The code compiles under Windows (cygwin & vs 6), I have not tried 
> compiling it with linux, so anyone who wants to give it a try, please 
> do so.
> 
> Additionally, I guess that the things I have done in the dissector 
> could probably optimized. I have just used calls that I got a glimpse 
> of within some of the other dissectors (rtp & rtp-events, rudp).
> So comments on how to improve the code are highly welcome ;-)
> 
> Best regards,
> Tobias
>  
> 
> > -----Ursprüngliche Nachricht-----
> > Von: wireshark-dev-bounces@xxxxxxxxxxxxx
> > [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] Im Auftrag von Tobias 
> > Erichsen
> > Gesendet: Freitag, 6. Oktober 2006 07:48
> > An: Developer support list for Wireshark
> > Betreff: Re: [Wireshark-dev] RTP-MIDI [heur]
> > 
> > I will do some final code-cleaning over the next couple of days, do 
> > some more testing and will post the code here some time during the 
> > weekend...
> > 
> > Tobias
> >  
> > 
> > > -----Ursprüngliche Nachricht-----
> > > Von: wireshark-dev-bounces@xxxxxxxxxxxxx
> > > [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] Im Auftrag von
> > Erwin Rol
> > > Gesendet: Donnerstag, 5. Oktober 2006 23:21
> > > An: Developer support list for Wireshark
> > > Betreff: Re: [Wireshark-dev] RTP-MIDI
> > > 
> > > On Thu, 2006-10-05 at 23:15 +0200, Tobias Erichsen wrote:
> > > > The problem is that RTP-MIDI does some "tweaking" to the
> > MIDI-data.
> > > > For example: System-Exclusive-data can be segmented
> into multiple
> > > > RTP-frames by ending a segment with a Status-Byte that
> > > would normally not be there.
> > > > Another thing is the fact that Realtime-Status-Bytes (just
> > > one octet
> > > > long) can be at any position in a "normal" midi-stream, but in 
> > > > RTP-MIDI they always "stand alone"...
> > > 
> > > But they still share a lot of "code", like all the command 
> > > descriptions etc.  Maybe the RTP-MIDI dissector can just be
> > extended
> > > to also do normal MIDI (one MIDI message per packet kind).
> > > 
> > > But anyway i hope your dissector is added soon, good work :-)
> > > 
> > > - Erwin
> > > 
> > > 
> > > _______________________________________________
> > > Wireshark-dev mailing list
> > > Wireshark-dev@xxxxxxxxxxxxx
> > > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> > > 
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> > 
> 
> 
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>