Wireshark-dev: [Wireshark-dev] [Patch] SCSI-OSD: reorder attributes page

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Joe Breher <linux@xxxxxxxxxxx>
Date: Sun, 08 Oct 2006 22:20:20 -0600
This patch fixes a transposition of the orders of
Set Attribute Number
Set Attribute Length
In the page oriented get and set attributes CDB parameters format
Ref SCSI-OSD T10/1355-D Revision 10 section 5.2.2.2

Index: epan/dissectors/packet-scsi-osd.c
===================================================================
--- epan/dissectors/packet-scsi-osd.c	(revision 19458)
+++ epan/dissectors/packet-scsi-osd.c	(working copy)
@@ -220,10 +220,10 @@
 		offset+=4;
 		proto_tree_add_item(tree, hf_scsi_osd_set_attributes_page, tvb, offset, 4, 0);
 		offset+=4;
+		proto_tree_add_item(tree, hf_scsi_osd_set_attribute_number, tvb, offset, 4, 0);
+		offset+=4;
 		proto_tree_add_item(tree, hf_scsi_osd_set_attribute_length, tvb, offset, 4, 0);
 		offset+=4;
-		proto_tree_add_item(tree, hf_scsi_osd_set_attribute_number, tvb, offset, 4, 0);
-		offset+=4;
 		proto_tree_add_item(tree, hf_scsi_osd_set_attributes_offset, tvb, offset, 4, 0);
 		offset+=4;
 		break;