[Guy Harris <guy@xxxxxxxxxxxx>]

On Jul 21, 2006, at 2:28 AM, Martin Mathieson wrote:

> I hadn't realised that gerald  fixed this (r18600) by making the  
> format
> string "%s". And of course every other call to proto_tree_add_text()
> I've seen uses a literal format string.

I don't know if any version of GCC has an option to warn about non- 
constant format strings; they can be useful (and, in fact, we use  
them), but it's useful to have some human check them to make sure  
they're really format strings rather than arbitrary strings.