Wireshark-dev: Re: [Wireshark-dev] [Patch] CDP dissector

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Fri, 23 Jun 2006 23:00:49 +0200 (CEST)
Hi,

Please switch off 'Colorize packet list' and clear the display filter.
Your additions disappear as snow in the sun.....

That is because your changes only work when the dissector is called with
tree != NULL. If it is not (in the circumstances described above) no
additional COL_INFO will be there.

Thanx,
Jaap

On Fri, 23 Jun 2006, Stephen Fisher wrote:

>
> I have attached a patch for the CDP (Cisco Discovery Protocol) dissector
> for consideration.  Almost every time that I am looking at CDP frames,
> it is to determine two things: the device name and the port number.  I
> suspect that this is the case for others also.  You have to open the
> tree for CDP, and then open the right two branches.  This patch adds
> these two values to the Info column.
>
> Old info column:
>
>   Cisco Discovery Protocol
>
> New info column:
>
>   Cisco Discovery Protocol  Device ID: switch.domain.com  Port ID: 3/5
>
>
> Thanks,
>   Steve
>
>