Wireshark-commits: [Wireshark-commits] master 4dac9c2: packet-q933: Decode LINK INTEGRITY + PVC STA

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Aug 2020 05:12:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4dac9c2c53d4fd1e3ea2c4a5018ad8f2c9d90410
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4dac9c2 by Harald Welte (laforge@xxxxxxxxxxx):

    packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without codeset
    
    I cannot find any mention in Q.933 that those two information elements
    should not be present in CS0.  In fact, multiple real-world traces
    I just recently took from Cisco and Ericsson equipment encodes
    those IEs in normal codset 0.
    
    This appears to have been broken since commit
    bafebc7b806e800741f8e982dd20e57ff69b1d28 in 2005, when the code was
    first introduced.
    
    Change-Id: I4c0ad080447d492b541cf7abd1e3f24a0e85084a
    Reviewed-on: https://code.wireshark.org/review/38212
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e7116cc   packet-fr: Treat DLCI=0 as Q.933 LMI if GPRS-NS is selected
     add  4dac9c2   packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without codeset


Summary of changes:
 epan/dissectors/packet-q933.c | 2 ++
 1 file changed, 2 insertions(+)