URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fed91de7a158a9fac68873eef4d02968eb2f326b
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
fed91de by Guy Harris (gharris@xxxxxxxxx):
ssh: make fields for string types FT_STRING rather than FT_STRINGZ.
To quote RFC 4251, "The Secure Shell (SSH) Protocol Architecture",
section 5 "Data Type Representations Used in the SSH Protocols":
string
Arbitrary length binary string. Strings are allowed to contain
arbitrary binary data, including null characters and 8-bit
characters. They are stored as a uint32 containing its length
(number of bytes that follow) and zero (= empty string) or more
bytes that are the value of the string. Terminating null
characters are not used.
Strings are also used to store text. In that case, US-ASCII is
used for internal names, and ISO-10646 UTF-8 for text that might
be displayed to the user. The terminating null character SHOULD
NOT normally be stored in the string. For example: the US-ASCII
string "testing" is represented as 00 00 00 07 t e s t i n g. The
UTF-8 mapping does not alter the encoding of US-ASCII characters.
"Terminating null characters are not used." means "these aren't
null-terminated strings; FT_STRINGZ is for null-terminated strings, but
these are counted strings, for which FT_STRING si the right type.
Change-Id: I217d527847a20b640bf141a5d8d56f31456af04c
Reviewed-on: https://code.wireshark.org/review/38118
Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
Actions performed:
from d5fe2d4 wsutil: define HAVE_LIBGCRYPT_AEAD in wsutil/wsgcrypt.h.
add fed91de ssh: make fields for string types FT_STRING rather than FT_STRINGZ.
Summary of changes:
epan/dissectors/packet-ssh.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)