Wireshark-commits: [Wireshark-commits] master-3.0 d24bc59: dicom: when exporting objects, don't ass

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Aug 2020 20:38:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d24bc59565ddc40da0b963cec9e03402893af738
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

d24bc59 by Guy Harris (gharris@xxxxxxxxx):

    dicom: when exporting objects, don't assume we have the AE titles.
    
    In dcm_export_create_object(), don't assume that assoc->ae_calling and
    assoc->ae_called are non-null; if we don't have an A-ASSOCIATE request
    earlier in the capture, which we are not guaranteed to have, the called
    and called AE titles won't be set.
    
    Bug: 16748
    Change-Id: I7d6d22d1c23e28b1f0967a803d0d89609a421712
    Reviewed-on: https://code.wireshark.org/review/38077
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 9015824c0ea3ee9ff265ae0db488bd3472d1875c)
    Reviewed-on: https://code.wireshark.org/review/38079
    

Actions performed:

    from  dbe0e6a   ieee80211-netmon: fix a typo.
     add  d24bc59   dicom: when exporting objects, don't assume we have the AE titles.


Summary of changes:
 epan/dissectors/packet-dcm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)