Wireshark-commits: [Wireshark-commits] master 458623f: ISUP: Decode Bellcore GR-317/GR-394 as ANSI

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 4 Aug 2020 05:20:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=458623fd871cd07086ee4226130a48fd100235e3
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

458623f by Richard Laager (rlaager@xxxxxxxxxx):

    ISUP: Decode Bellcore GR-317/GR-394 as ANSI
    
    Bellcore (now Telcordia) GR-317 and GR-394 are used in the U.S. and are
    more similar to ANSI ISUP than ITU Standard ISUP.  This fixes decoding
    the Jurisdiction (aka JIP) optional parameter.
    
    "gr317" is listed in RFC 3204, Table 1 on Page 2.  Telcordia's name for
    this standard is "LSSGR: Switching System Generic Requirements for Call
    Control Using the Integrated Services Digital Network User Part
    (ISDNUP)".
    
    "gr394" is the value used by our Ribbon (formerly Genband) C15 switch.
    Telcordia's name for GR-394 is "LSSGR: Switching System Generic
    Requirements for Interexchange Carrier Interconnection (ICI) Using The
    Integrated Services Digital Network User Part (ISDNUP)".  The difference
    from GR-317 is "Call Control" vs "Interexchange Carrier Interconnection
    (ICI)".  These calls are indeed interexchange calls.
    
    Given that only "gr317" is listed in RFC 3204, arguably our Ribbon C15
    should be sending this as "version=gr394; base=gr317" or just as
    "version=gr317", but I have no control over that and would like to
    decode the traffic as seen in the wild.
    
    Bug: 16752
    Change-Id: I24c7b2e175606e1c91bcb2e96a3372f62055e293
    Reviewed-on: https://code.wireshark.org/review/38038
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a381adf   wiretap: fix an internal routine's name.
     add  458623f   ISUP: Decode Bellcore GR-317/GR-394 as ANSI


Summary of changes:
 epan/dissectors/packet-isup.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)