Wireshark-commits: [Wireshark-commits] master 1977417: GeoNW: properly display lists of HashedId3

Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 31 Jul 2020 20:48:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1977417385d2a1b7830ea435a550b0ffee8cfe0c
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1977417 by Marios Makassikis (mmakassikis@xxxxxxxxx):

    GeoNW: properly display lists of HashedId3
    
    Currently, if the sequence of HashedId3 is 111111222222333333, wireshark
    will display the following 3 elements:
     * 111111222222333333
     * 222222333333
     * 333333
    
    This is wrong, as a HashedId3 is defined as a 3 byte ID.
    
    This patch makes sure we only output 3 bytes at a time, so the output
    will look like the following:
     * 111111
     * 222222
     * 333333
    
    Change-Id: I331ef473a452c3574bfca90fe2180ae27f93a480
    Reviewed-on: https://code.wireshark.org/review/37996
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  5d0f013   GeoNW: Fix parsing of ecies_nistp256 public keys
     add  1977417   GeoNW: properly display lists of HashedId3


Summary of changes:
 epan/dissectors/packet-geonw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)