Wireshark-commits: [Wireshark-commits] master a4ebc98: iptrace: various cleanups.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Jul 2020 09:21:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4ebc98fa4b2327e1ab2fa402c21585083a9a8ab
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a4ebc98 by Guy Harris (gharris@xxxxxxxxx):

    iptrace: various cleanups.
    
    Call the "iptrace X.Y" string we read in the version string, rather than
    the name.
    
    Get rid of the structures defining various parts of the file format.
    Instead, have #defines for offsets.
    
    Read the record header - the first 8 octets - first.  Check the record
    length, to make sure it's large enough to include the packet information
    structure, before we try to read that structure.
    
    Note that one octet in the packet information structure is the unit
    number for the interface on which the packet arrived, the field that was
    called the name is the prefix of the name (in the sense that, for
    example, in "en0", "en" is the prefix and "0" is the unit number), and
    that what was called the "description" isn't as simple as a description
    of the interface on which the packet arrived.
    
    Pass the field that was called the "description" to
    fill_in_pseudo_header(), as, for ATM PDUs, it contains, among other
    things, an indication of the VPI and VCI for the PDU, as well as a
    direction indication.
    
    Change-Id: I8703b046142dd41ca96bda00c2fa3d2edb66b837
    Reviewed-on: https://code.wireshark.org/review/37974
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  45ab688   FTDI MPSSE: Fix handling responses without command
     add  a4ebc98   iptrace: various cleanups.


Summary of changes:
 wiretap/iptrace.c | 221 +++++++++++++++++++++++++++++++++---------------------
 1 file changed, 136 insertions(+), 85 deletions(-)