Wireshark-commits: [Wireshark-commits] master 08b3414: RTPS: catch another use of an uninitialized

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Jul 2020 22:50:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08b3414d17f5cf3c508924bdc8b932560b0231b3
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

08b3414 by Guy Harris (gharris@xxxxxxxxx):

    RTPS: catch another use of an uninitialized structure member.
    
    rtps_util_add_type_element_module() does not set anything in the
    dissector_info structure, so 1) don't pass it a pointer to that
    structure and 2) don't add the info structure to the dissection_infos
    table.
    
    Bug: 16717
    Change-Id: I963b2da0c75124174396714ef5aa68ffe3862f3e
    Reviewed-on: https://code.wireshark.org/review/37910
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  40dee6e   sshdump: clarify integration with Wireshark
     add  08b3414   RTPS: catch another use of an uninitialized structure member.


Summary of changes:
 epan/dissectors/packet-rtps.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)