Wireshark-commits: [Wireshark-commits] master 69216a3: QUIC: fix decryption when the client uses an

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Jul 2020 05:53:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69216a385dfadfe7b40b6dd5f33130f7f2a4d790
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

69216a3 by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fix decryption when the client uses an empty SCID
    
    Decryption of short header packets would fail if the client sends a SCID
    due to a logic error. This was observed with Chrome 86.0.4198.2.
    
    Thanks to Ashwin Jagadish for the report and sample capture.
    
    Change-Id: I81f5ab1bc1ea1b379e4edd65969d3c3e58340065
    Ping-Bug: 13881
    Fixes: v2.9.0rc0-269-gec30d0b004 ("QUIC: implement connection migration (draft -10 and -11)")
    Reviewed-on: https://code.wireshark.org/review/37830
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  34c2353   QUIC: improve display of unknown or large Transport Parameter types
     add  69216a3   QUIC: fix decryption when the client uses an empty SCID


Summary of changes:
 epan/dissectors/packet-quic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)