URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39b4d2eb3e9911937b9119f80dd0b6c59b809ebc
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
39b4d2e by Vadim Yanitskiy (vyanitskiy@xxxxxxxxxxx):
A-bis/RSL: fix dissection of Mobile Allocation in CHANnel ACTIVation
According to 3GPP TS 48.058 (version 15.0.0), section 9.3.5,
3GPP TS 44.018 "Mobile Allocation" IE shall for compatibility
reasons be included but empty, i.e. the length shall be zero.
It does not mean that the Mobile Allocation IE should not be
decoded by Wireshark though. Some BSC implementations may still
be sending it with length greather than 0.
Let's expose de_rr_mob_all() and use it in dissect_rsl_ie_ch_id().
If the length is greather than 0, raise a protocol warning.
Change-Id: Idd0f2b3cd1e684f2c812b566fde71a1cc727c2c4
Signed-off-by: Vadim Yanitskiy <vyanitskiy@xxxxxxxxxxx>
Reviewed-on: https://code.wireshark.org/review/37575
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 408bc4c Qt: Add keyboard shortcut for Decode As
add 39b4d2e A-bis/RSL: fix dissection of Mobile Allocation in CHANnel ACTIVation
Summary of changes:
epan/dissectors/packet-gsm_a_common.h | 1 +
epan/dissectors/packet-gsm_a_rr.c | 2 +-
epan/dissectors/packet-rsl.c | 27 +++++++++++++++++++++------
3 files changed, 23 insertions(+), 7 deletions(-)