URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e312d073677232e63d3603d6e990b263da87ceef
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
e312d07 by Matthew Weant (msweant@xxxxxxxxx):
EAP: Handling Identities with Periods
Fixing EAP WLAN identity dissection to account for
identities that contain periods. Also fixed an issue
with the identity unknown data field where it would
incorrectly calculate the number of remaining bytes
in identity messages. In that same vein, renamed the
field from hf_eap_identity_unknown_data to
hf_eap_identity_padding as it is only null bytes appended
to the end of identity strings. Lastly, I corrected
the EAP WLAN identity MCC and MNC lookup logic. It
wrongly assumed that NAI Realm MCC and MNCs should only
exist or dissect with permanent EAP identities which
is not the case. The algorithm used to perform lookups
would also not resolve all MCC/MNC pairs for the MNC value.
Bug: 16524
Change-Id: I1d9955618dab0c70de9fcd88088a4390989653c7
Reviewed-on: https://code.wireshark.org/review/37250
Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from d592e47 ASTERIX: add dissection of I001/050 and I001/060
add e312d07 EAP: Handling Identities with Periods
Summary of changes:
epan/dissectors/packet-eap.c | 87 ++++++++++++++++++++++++++++++++------------
1 file changed, 63 insertions(+), 24 deletions(-)