Wireshark-commits: [Wireshark-commits] master 5b88524: MAC-NR: get rid of an unnecessary level of i

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Jun 2020 22:14:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b885240b7b39972450dac85f3d0fb52255246e3
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5b88524 by Guy Harris (gharris@xxxxxxxxx):

    MAC-NR: get rid of an unnecessary level of indirection.
    
    Don't take the address of an hf_ field and then, in the called routine,
    dereference the pointer; just pass the hf_ field value.  In the cases
    where we're passing a member of an array of pointers, dereference the
    pointer at the call site.
    
    Change-Id: I022ce46c196621088e093f9a43d57b4653c957f7
    Reviewed-on: https://code.wireshark.org/review/37526
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  1f8c4ec   QUIC: print helpful hints when Libgcrypt is too old
     add  5b88524   MAC-NR: get rid of an unnecessary level of indirection.


Summary of changes:
 epan/dissectors/packet-mac-nr.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)