[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e1d9a226a2b8f2824a0eb162a8dc972e6e6c2dd4
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e1d9a226 by Guy Harris (gharris@xxxxxxxxx):

    Fix the type of arrays of pointers to hf_ values for bitfield routines.
    
    The static arrays are supposed to be arrays of const pointers to int,
    not arrays of non-const pointers to const int.
    
    Fixing that means some bugs (scribbling on what's *supposed* to be a
    const array) will be caught (see packet-ieee80211-radiotap.c for
    examples, the first of which inspired this change and the second of
    which was discovered while testing compiles with this change), and
    removes the need for some annoying casts.
    
    Also make some of those arrays static while we're at it.
    
    Update documentation and dissector-generator tools.
    
    Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc
    Reviewed-on: https://code.wireshark.org/review/37517
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  51bb2c4   README.X11: update.
     add  e1d9a226  Fix the type of arrays of pointers to hf_ values for bitfield routines.


Summary of changes:
 doc/README.dissector                               |   2 +-
 docbook/wsdg_src/WSDG_chapter_dissection.adoc      |   2 +-
 epan/dissectors/asn1/c1222/packet-c1222-template.c |   2 +-
 epan/dissectors/asn1/its/packet-its-template.c     |   4 +-
 .../asn1/kerberos/packet-kerberos-template.c       |   6 +-
 epan/dissectors/asn1/ldap/ldap.cnf                 |   2 +-
 epan/dissectors/asn1/ldap/packet-ldap-template.c   |   6 +-
 epan/dissectors/asn1/lte-rrc/lte-rrc.cnf           |   2 +-
 epan/dissectors/asn1/ngap/ngap.cnf                 |  12 +-
 epan/dissectors/asn1/s1ap/s1ap.cnf                 |  16 +-
 .../asn1/spnego/packet-spnego-template.c           |   2 +-
 epan/dissectors/asn1/sv/packet-sv-template.c       |   2 +-
 epan/dissectors/asn1/x2ap/x2ap.cnf                 |  20 +-
 epan/dissectors/file-mp4.c                         |   6 +-
 epan/dissectors/file-pcapng.c                      |   8 +-
 epan/dissectors/packet-3g-a11.c                    |   2 +-
 epan/dissectors/packet-6lowpan.c                   |   6 +-
 epan/dissectors/packet-9p.c                        |   2 +-
 epan/dissectors/packet-a21.c                       |   2 +-
 epan/dissectors/packet-acdr.c                      |   4 +-
 epan/dissectors/packet-acp133.c                    |   2 +-
 epan/dissectors/packet-acse.c                      |   6 +-
 epan/dissectors/packet-adwin-config.c              |   2 +-
 epan/dissectors/packet-aeron.c                     |   8 +-
 epan/dissectors/packet-afp.c                       |  34 +-
 epan/dissectors/packet-afs.c                       |   4 +-
 epan/dissectors/packet-agentx.c                    |   2 +-
 epan/dissectors/packet-aim.c                       |   8 +-
 epan/dissectors/packet-ain.c                       |  22 +-
 epan/dissectors/packet-amp.c                       |   6 +-
 epan/dissectors/packet-ansi_801.c                  |   4 +-
 epan/dissectors/packet-aodv.c                      |  12 +-
 epan/dissectors/packet-artnet.c                    |  18 +-
 epan/dissectors/packet-assa_r3.c                   |   8 +-
 epan/dissectors/packet-atalk.c                     |   2 +-
 epan/dissectors/packet-atn-ulcs.c                  |   6 +-
 epan/dissectors/packet-autosar-nm.c                |   4 +-
 epan/dissectors/packet-awdl.c                      |  16 +-
 epan/dissectors/packet-bacnet.c                    |   6 +-
 epan/dissectors/packet-bat.c                       |   2 +-
 epan/dissectors/packet-batadv.c                    |  28 +-
 epan/dissectors/packet-ber.c                       |   8 +-
 epan/dissectors/packet-ber.h                       |   4 +-
 epan/dissectors/packet-bfd.c                       |   4 +-
 epan/dissectors/packet-bgp.c                       |  58 +--
 epan/dissectors/packet-bmp.c                       |   4 +-
 epan/dissectors/packet-bpdu.c                      |   6 +-
 epan/dissectors/packet-brdwlk.c                    |   2 +-
 epan/dissectors/packet-bssgp.c                     |   4 +-
 epan/dissectors/packet-btatt.c                     | 168 +++----
 epan/dissectors/packet-btbredr_rf.c                |   2 +-
 epan/dissectors/packet-bthci_cmd.c                 |  40 +-
 epan/dissectors/packet-bthci_evt.c                 |  14 +-
 epan/dissectors/packet-bthci_vendor.c              |   6 +-
 epan/dissectors/packet-bthfp.c                     |   6 +-
 epan/dissectors/packet-btle.c                      |  14 +-
 epan/dissectors/packet-btle_rf.c                   |   2 +-
 epan/dissectors/packet-btmesh.c                    |   6 +-
 epan/dissectors/packet-btsdp.c                     |  14 +-
 epan/dissectors/packet-btsmp.c                     |   4 +-
 epan/dissectors/packet-c1222.c                     |   2 +-
 epan/dissectors/packet-canopen.c                   |  56 +--
 epan/dissectors/packet-capwap.c                    |  16 +-
 epan/dissectors/packet-cattp.c                     |   2 +-
 epan/dissectors/packet-ccsds.c                     |   2 +-
 epan/dissectors/packet-ceph.c                      |  12 +-
 epan/dissectors/packet-cesoeth.c                   |   4 +-
 epan/dissectors/packet-cfdp.c                      |  24 +-
 epan/dissectors/packet-charging_ase.c              |  12 +-
 epan/dissectors/packet-cip.c                       |  14 +-
 epan/dissectors/packet-cipmotion.c                 |  28 +-
 epan/dissectors/packet-cipsafety.c                 |   6 +-
 epan/dissectors/packet-cmip.c                      |   6 +-
 epan/dissectors/packet-cmp.c                       |   2 +-
 epan/dissectors/packet-cnip.c                      |   2 +-
 epan/dissectors/packet-cops.c                      |   2 +-
 epan/dissectors/packet-couchbase.c                 |  26 +-
 epan/dissectors/packet-cp2179.c                    |   4 +-
 epan/dissectors/packet-cql.c                       |   8 +-
 epan/dissectors/packet-csm-encaps.c                |   2 +-
 epan/dissectors/packet-dap.c                       |  10 +-
 epan/dissectors/packet-dcerpc-atsvc.c              |   6 +-
 epan/dissectors/packet-dcerpc-clusapi.c            |   8 +-
 epan/dissectors/packet-dcerpc-dfs.c                |   6 +-
 epan/dissectors/packet-dcerpc-dnsserver.c          |   8 +-
 epan/dissectors/packet-dcerpc-dssetup.c            |   2 +-
 epan/dissectors/packet-dcerpc-eventlog.c           |   4 +-
 epan/dissectors/packet-dcerpc-frsrpc.c             |   6 +-
 epan/dissectors/packet-dcerpc-frstrans.c           |   2 +-
 epan/dissectors/packet-dcerpc-initshutdown.c       |   2 +-
 epan/dissectors/packet-dcerpc-lsa.c                |   8 +-
 epan/dissectors/packet-dcerpc-mapi.c               |   2 +-
 epan/dissectors/packet-dcerpc-netlogon.c           |  20 +-
 epan/dissectors/packet-dcerpc-nt.c                 |   2 +-
 epan/dissectors/packet-dcerpc-samr.c               |  20 +-
... 373 lines suppressed ...