Wireshark-commits: [Wireshark-commits] master d91b0d5: acdr: cleaner test for "is this tree item an

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Jun 2020 13:55:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d91b0d560a810f3e394c4b76298c7f29afd9b567
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d91b0d5 by Guy Harris (gharris@xxxxxxxxx):

    acdr: cleaner test for "is this tree item an RTP item?"
    
    Don't rely on the item having the name "Real-Time Transport Protocol",
    as that's fragile.  We could check for the abbreviation or filter name
    being "rtp", but we can avoid string comparisons entirely by getting the
    ID for the protocol "rtp" and comparing the item's ID with that.
    
    Change-Id: I2a859f0b346f15a797fb5de75e0cf5c0b5abcfe9
    Reviewed-on: https://code.wireshark.org/review/37490
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Reviewed-by: Orgad Shaneh <orgads@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  67e70dc   proto: clean up comments.
     add  d91b0d5   acdr: cleaner test for "is this tree item an RTP item?"


Summary of changes:
 epan/dissectors/packet-acdr.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)