Wireshark-commits: [Wireshark-commits] master f585829: packet-kerberos: maintain EncAPRepPart_subke

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 May 2020 12:08:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5858299a92520163ca5598e1caca4f68179b349
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f585829 by Stefan Metzmacher (metze@xxxxxxxxx):

    packet-kerberos: maintain EncAPRepPart_subkey in a kerberos_app_session_keys map
    
    This improves the performance a lot if you have a keytab with a lot of
    entries (e.g. for a whole domain).
    
    GSSKRB5 decryption should only try the subkey of the AP-Rep.
    
    We could further optimize this and remember the key
    on the cenversation after the first success, but
    that's for another day.
    
    Change-Id: I405e41e7d90073d569fcbeec4b4188453a251000
    Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/37323
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8b35c40   packet-{kerberos,spnego}: move KRB5_KU_USAGE_* defined to packet-kerberos.h
     add  f585829   packet-kerberos: maintain EncAPRepPart_subkey in a kerberos_app_session_keys map


Summary of changes:
 .../asn1/kerberos/packet-kerberos-template.c       | 41 +++++++++++++++++--
 epan/dissectors/packet-kerberos.c                  | 47 +++++++++++++++++++---
 2 files changed, 79 insertions(+), 9 deletions(-)