Wireshark-commits: [Wireshark-commits] master 65806b6: TCP: Add expert info for ignored TCP Fast Op

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 May 2020 16:41:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=65806b69c5e1e58ffbd157c51837fb450da61f06
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

65806b6 by Peter Wu (peter@xxxxxxxxxxxxx):

    TCP: Add expert info for ignored TCP Fast Open data
    
    Report case 2b from https://tools.ietf.org/html/rfc7413#page-6 where the
    server drops the data and sends a SYN-ACK acknowleding only the SYN
    sequence number. Tested with tfo.pcapng from the linked bug.
    
    Bug: 16559
    Change-Id: Ia03b923f8192f025e2e81716e615d49db4bafe91
    Reviewed-on: https://code.wireshark.org/review/37161
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  099d241   dot11decrypt: Avoid allocating SA on packet decryption
     add  65806b6   TCP: Add expert info for ignored TCP Fast Open data


Summary of changes:
 epan/dissectors/packet-tcp.c | 15 ++++++++++++++-
 epan/dissectors/packet-tcp.h |  5 +++++
 2 files changed, 19 insertions(+), 1 deletion(-)