Wireshark-commits: [Wireshark-commits] master c0a4b8b: ENIP: Code Cleanup

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 May 2020 05:37:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0a4b8b30f332c432504e424ec42bbd055ee9a27
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c0a4b8b by Dylan Ulis (daulis0@xxxxxxxxx):

    ENIP: Code Cleanup
    
    No real functional changes:
    1. Remove some types that don't appear in the spec
    2. Change some variable names and text descriptions to match spec
    3. Pull out some logic to separate functions
    4. Correct variable types to match the interface types
    
    Change-Id: I82ae74fd709c2ec893d20c50eaa36f6c86e20634
    Reviewed-on: https://code.wireshark.org/review/37162
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  63a8ac5   Qt: Respect user preference to hide packet list
     add  c0a4b8b   ENIP: Code Cleanup


Summary of changes:
 epan/dissectors/packet-enip.c | 205 ++++++++++++++++++++----------------------
 1 file changed, 98 insertions(+), 107 deletions(-)