URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1408dd3b5022cf5b4f7545440cd5839c784a4764
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
1408dd3 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):
Last batch of changes from PVS-Studio scan.
/opt/SourceCode/wireshark/epan/dissectors/packet-flip.c 155 warn V547 Expression 'chksum_hdr_chksum == computed_chksum' is always false.
/opt/SourceCode/wireshark/epan/dissectors/packet-zbee-zcl-meas-sensing.c 1295 err V590 Consider inspecting the '(value > 0x0000) || (value > 0xfffd)' expression. The expression is excessive or contains a misprint.
/opt/SourceCode/wireshark/ui/qt/lte_rlc_statistics_dialog.cpp 504 warn V668 There is no sense in testing the 'channel_item' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Bug: 16335
Change-Id: Ief19a82e84bd16df33c453d6cc30db37f1c589ea
Reviewed-on: https://code.wireshark.org/review/37150
Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
Actions performed:
from f263df0 SOMEIP: removing warnings due to guint64 (%lx vs %llx)
add 1408dd3 Last batch of changes from PVS-Studio scan.
Summary of changes:
epan/dissectors/packet-flip.c | 3 +--
epan/dissectors/packet-zbee-zcl-meas-sensing.c | 2 +-
ui/qt/lte_rlc_statistics_dialog.cpp | 4 +---
3 files changed, 3 insertions(+), 6 deletions(-)