Wireshark-commits: [Wireshark-commits] master-3.0 fa65578: voip_calls: Fix leak of GString from uni

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 May 2020 19:08:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa65578bfa0984ca8df005f914e6b9a5877a21f0
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

fa65578 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    voip_calls: Fix leak of GString from unistim handling.
    
    /opt/SourceCode/wireshark/ui/voip_calls.c	3786	err	V773 The function was exited without releasing the 'g_tmp' pointer. A memory leak is possible.
    
    Tested with unistim_call.pcap from SampleCaptures.
    
    Bug: 16335
    Change-Id: I8518a3e277e8acec15e09ca5f36672b5bdd181fe
    Reviewed-on: https://code.wireshark.org/review/37028
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 0b1e27ec774b65c157dd2f5de387f73a25ae306e)
    Reviewed-on: https://code.wireshark.org/review/37077
    

Actions performed:

    from  56ff9e5   Some more issues identified by PVS-Studio.
     add  fa65578   voip_calls: Fix leak of GString from unistim handling.


Summary of changes:
 ui/voip_calls.c | 1 +
 1 file changed, 1 insertion(+)