Wireshark-commits: [Wireshark-commits] master-3.2 aa2976d: Some more issues identified by PVS-Studi
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 May 2020 19:05:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa2976dab356fea0c6826768d0bef4a9eac71c54 Submitter: "Guy Harris <gharris@xxxxxxxxx>" Changed: branch: master-3.2 Repository: wireshark Commits: aa2976d by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx): Some more issues identified by PVS-Studio. /opt/SourceCode/wireshark/epan/dissectors/packet-osc.c 367 err V562 It's odd to compare 0 or 1 with a value of 0. /opt/SourceCode/wireshark/epan/dissectors/packet-rpc.c 960 note V576 Incorrect format. Consider checking the eighth actual argument of the 'proto_tree_add_subtree_format' function. The SIGNED integer type argument is expected. /opt/SourceCode/wireshark/epan/dissectors/packet-rpc.c 980 note V576 Incorrect format. Consider checking the third actual argument of the 'proto_item_append_text' function. The SIGNED integer type argument is expected. /opt/SourceCode/wireshark/epan/dissectors/packet-rpc.c 2473 note V576 Incorrect format. Consider checking the fourth actual argument of the 'col_prepend_fstr' function. The SIGNED integer type argument is expected. /opt/SourceCode/wireshark/epan/dissectors/packet-rpc.c 2482 note V576 Incorrect format. Consider checking the fourth actual argument of the 'col_append_fstr' function. The SIGNED integer type argument is expected. /opt/SourceCode/wireshark/epan/dissectors/packet-rpc.c 2633 note V576 Incorrect format. Consider checking the fourth actual argument of the 'col_append_fstr' function. The SIGNED integer type argument is expected. /opt/SourceCode/wireshark/epan/dissectors/packet-rpc.c 2650 note V576 Incorrect format. Consider checking the fourth actual argument of the 'col_prepend_fstr' function. The SIGNED integer type argument is expected. /opt/SourceCode/wireshark/epan/dissectors/packet-stun.c 565 warn V1051 Consider checking for misprints. It's possible that the 'reported_length' should be checked here. /opt/SourceCode/wireshark/epan/dissectors/packet-umts_fp.c 4126 warn V1051 Consider checking for misprints. It's possible that the 'reported_length' should be checked here. /opt/SourceCode/wireshark/epan/dissectors/packet-umts_fp.c 4942 warn V1051 Consider checking for misprints. It's possible that the 'reported_length' should be checked here. /opt/SourceCode/wireshark/ui/voip_calls.c 1444 err V773 The 'comment' pointer was assigned values twice without releasing the memory. A memory leak is possible. /opt/SourceCode/wireshark/wsutil/filesystem.c 1531 err V773 The function was exited without releasing the 'files' pointer. A memory leak is possible. /opt/SourceCode/wireshark/wsutil/filesystem.c 1717 err V773 The function was exited without releasing the 'files' pointer. A memory leak is possible. Bug: 16335 Change-Id: I8df3ba6d070823dcb43c4152d9156358f701e8dc Reviewed-on: https://code.wireshark.org/review/37069 Petri-Dish: Guy Harris <gharris@xxxxxxxxx> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@xxxxxxxxx> (cherry picked from commit 6ba8bd037f46b7dbb0e82ca79ad1d0cfbbe0eda9) Reviewed-on: https://code.wireshark.org/review/37073 Actions performed: from 70586d5 [Automatic update for 2020-05-03] add aa2976d Some more issues identified by PVS-Studio. Summary of changes: epan/dissectors/packet-osc.c | 2 +- epan/dissectors/packet-rpc.c | 12 ++++++------ epan/dissectors/packet-stun.c | 2 +- epan/dissectors/packet-umts_fp.c | 10 ++++------ ui/voip_calls.c | 4 ++++ wsutil/filesystem.c | 10 ++++++---- 6 files changed, 22 insertions(+), 18 deletions(-)
- Prev by Date: [Wireshark-commits] master 6ba8bd0: Some more issues identified by PVS-Studio.
- Next by Date: [Wireshark-commits] master-3.0 56ff9e5: Some more issues identified by PVS-Studio.
- Previous by thread: [Wireshark-commits] master 6ba8bd0: Some more issues identified by PVS-Studio.
- Next by thread: [Wireshark-commits] master-3.0 56ff9e5: Some more issues identified by PVS-Studio.
- Index(es):