Wireshark-commits: [Wireshark-commits] master-3.2 bed111f: stats_tree: plug a memory leak.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 May 2020 06:39:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bed111fa43eba304566309a03978170b52c286e2
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

bed111f by Guy Harris (guy@xxxxxxxxxxxx):

    stats_tree: plug a memory leak.
    
    Don't allocate the GString until we know we'll be using it.
    
    Change-Id: I97e2f897795ada864cbacc3822d39e7348a93ca2
    Ping-Bug: 16335
    Reviewed-on: https://code.wireshark.org/review/37048
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit c22b2ccd94e4e0e5f71e2cb6bae5b9e2abe7ebf4)
    Reviewed-on: https://code.wireshark.org/review/37056
    

Actions performed:

    from  91a621e   More issues spotted by PVS-Studio in bug 16335.
     add  bed111f   stats_tree: plug a memory leak.


Summary of changes:
 rawshark.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)