Wireshark-commits: [Wireshark-commits] master d5fc969: No explicit glib.h include required

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 May 2020 21:28:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5fc969e578a1e3a3eccb03b1586cbadd58107a5
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d5fc969 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    No explicit glib.h include required
    
    Stop including glib.h in dissectors, this will come in implicitly with
    packet.h including proto.h, an essential include file for dissectors.
    While at it, config.h is no longer conditional and stdio.h is usually
    not needed either. Some other cleanups too.
    
    Change-Id: I60c12f16d7ef1e6398509293031ffed7460d2c61
    Reviewed-on: https://code.wireshark.org/review/36969
    Reviewed-by: Orgad Shaneh <orgads@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  f358654   mpeg: make sure the presence flags are set.
     add  d5fc969   No explicit glib.h include required


Summary of changes:
 epan/dissectors/asn1/lnpdqp/packet-lnpdqp-template.c |  1 -
 epan/dissectors/asn1/mms/packet-mms-template.c       |  3 ---
 epan/dissectors/asn1/z3950/packet-z3950-template.c   |  6 +-----
 epan/dissectors/packet-acdr.c                        |  1 -
 epan/dissectors/packet-btatt.c                       |  1 -
 epan/dissectors/packet-cemi.c                        |  2 ++
 epan/dissectors/packet-couchbase.c                   |  2 --
 epan/dissectors/packet-dji-uav.c                     |  1 -
 epan/dissectors/packet-dof.c                         |  2 --
 epan/dissectors/packet-ecmp.c                        |  1 -
 epan/dissectors/packet-epl-profile-parser.c          |  2 --
 epan/dissectors/packet-epl.c                         |  1 -
 epan/dissectors/packet-f5ethtrailer.c                |  1 -
 epan/dissectors/packet-fc00.c                        |  2 --
 epan/dissectors/packet-h248_10.c                     |  1 -
 epan/dissectors/packet-isi.c                         |  1 -
 epan/dissectors/packet-jxta.h                        |  5 +++--
 epan/dissectors/packet-knxip.c                       | 14 +++++++++++++-
 epan/dissectors/packet-knxip.h                       | 11 -----------
 epan/dissectors/packet-lat.c                         |  2 --
 epan/dissectors/packet-lnpdqp.c                      | 11 +++++------
 epan/dissectors/packet-metamako.c                    |  1 -
 epan/dissectors/packet-mle.c                         |  1 -
 epan/dissectors/packet-mms.c                         | 13 +++++--------
 epan/dissectors/packet-pcp.c                         |  1 -
 epan/dissectors/packet-portmap.c                     |  6 +++---
 epan/dissectors/packet-rpc.h                         |  1 -
 epan/dissectors/packet-rtitcp.c                      |  1 -
 epan/dissectors/packet-rtsp.c                        |  1 -
 epan/dissectors/packet-shim6.c                       |  2 --
 epan/dissectors/packet-smb2.c                        |  1 -
 epan/dissectors/packet-snort-config.c                |  1 +
 epan/dissectors/packet-snort-config.h                |  5 +----
 epan/dissectors/packet-someip-sd.c                   |  2 --
 epan/dissectors/packet-someip.c                      |  3 +--
 epan/dissectors/packet-srt.c                         |  2 --
 epan/dissectors/packet-thread.c                      |  1 -
 epan/dissectors/packet-z3950.c                       | 18 +++++++-----------
 38 files changed, 42 insertions(+), 89 deletions(-)