URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76b530eb6acb1efa4e28254325a8ab4dac6b7db3
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
76b530e by Jason Cohen (j.cohen@xxxxxx):
eth: require padding to be zeros by default
Ethernet frame padding for short frames _should_ be zeros. Replace
the assume_padding preference with the padding preference that by default
will only consider consecutive zeros long enough to reach the minimum
ethernet length to be padding. The old behaviors are preserved.
Never (old FALSE) and Any (old TRUE - old default)
The old behavior broke some trailer dissectors when the trailer was
added before the determination of needing padding was made. Thus the
ethernet dissector would consume some of the trailer as padding.
Bug: 16481
Change-Id: I6b9e1d26d07d84cb768eece5e44412e23dfe37ca
Reviewed-on: https://code.wireshark.org/review/36691
Reviewed-by: Jason Cohen <kryojenik2@xxxxxxxxx>
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 15b53b6 wireshark_zip_helper(Qt): fix no previous prototype for function
add 76b530e eth: require padding to be zeros by default
Summary of changes:
epan/dissectors/packet-eth.c | 88 +++++++++++++++++++++++++++++++-------------
1 file changed, 63 insertions(+), 25 deletions(-)