Wireshark-commits: [Wireshark-commits] master 16dad84: USBLL: Improve the dissection of Split packe

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Apr 2020 10:58:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16dad84dd7dabf393e6924db5996dab03f490165
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

16dad84 by Ameya Deshpande (ameya.181co205@xxxxxxxxxxx):

    USBLL: Improve the dissection of Split packets
    
    Split Start and Split Complete have a difference of one field.
    In Split Start, it is E whereas in Split Complete, it is U.
    The U field is unused and always 0.
    The E field is also always 0 for transfers except Split Isochronous
    OUT.
    For Split Isochronous OUT, S/E have a special meaning.
    We display this special meaning only for Split Start packets as
    they don't have Split Complete transactions.
    
    Ping-Bug: 15908
    Change-Id: I2470ac86fb13fd2749a8feeb083ac0b325b218b6
    Signed-off-by: Ameya Deshpande <ameya.181co205@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36764
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3d78523   USBLL: Set usbll_data_ptr to NULL on capture file close
     add  16dad84   USBLL: Improve the dissection of Split packets


Summary of changes:
 epan/dissectors/packet-usbll.c | 72 +++++++++++++++++++++++++++---------------
 1 file changed, 47 insertions(+), 25 deletions(-)