Wireshark-commits: [Wireshark-commits] master-3.2 f7537ea: tshark: fix use-after-free while closing

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 08 Apr 2020 21:58:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7537ea094d9132f3bebba638b4dc595f5f5df75
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

f7537ea by Peter Wu (peter@xxxxxxxxxxxxx):

    tshark: fix use-after-free while closing a live capture file
    
    wtap_cleanup() clears options which are still in use by the time
    cf_close calls wtap_close. Be sure to close the capture file first.
    
    Bug: 16487
    Change-Id: Id9ef1c0321865e9574b69439870a842efb2b209b
    Fixes: v3.3.0rc0-853-g3662a69036 ("Maintain cf->state, because file cleanup depends on it.")
    Reviewed-on: https://code.wireshark.org/review/36755
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 33aec15e4a0a5fd151d0c5141853af3d9e70489a)
    Reviewed-on: https://code.wireshark.org/review/36756
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  8a8a1fb   Build 3.2.3.
     add  f7537ea   tshark: fix use-after-free while closing a live capture file


Summary of changes:
 tshark.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)