Wireshark-commits: [Wireshark-commits] master-3.2 4738fec: BACapp: Add a nesting / recursion check.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 07 Apr 2020 16:10:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4738fec56ddc09db7807cbdd63118aad327a6f2f
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

4738fec by Gerald Combs (gerald@xxxxxxxxxxxxx):

    BACapp: Add a nesting / recursion check.
    
    Track our recursion depth in fAbstractSyntaxNType. It calls several
    functions which in turn call it, which makes it easy to overflow the
    stack.
    
    Bug: 16474
    Change-Id: Ibad29272f99449bfa13b7422692e20ba8a79e19c
    Reviewed-on: https://code.wireshark.org/review/36725
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 15dc2f6bd4c9a674333cbc97260362524d5364de)
    Reviewed-on: https://code.wireshark.org/review/36734
    

Actions performed:

    from  141a4b1   proto: remove a temporary variable
     add  4738fec   BACapp: Add a nesting / recursion check.


Summary of changes:
 epan/dissectors/packet-bacapp.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)