Wireshark-commits: [Wireshark-commits] master e4bfd8b: dot11decrypt: Silent Coverity Scan out-of-bo

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 05 Apr 2020 08:30:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4bfd8b19e9e52d05ab146d6e6a690efe9a47935
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e4bfd8b by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Silent Coverity Scan out-of-bounds access error
    
    Coverity Scan reports an out-of-bounds acccess on memcopy from addr1
    of 802.11 mac header. This out-of-bounds access is a controlled access
    knowing that addr2 and addr3 is located in memory right after addr1.
    Type cast to a guint8 pointer to indicate that there's no fix length.
    This should silent the Coverity Scan error reported.
    
    Coverity CID 1460754
    
    Change-Id: Ief2280f1b686deebf3aba74f19a5730c66d4d313
    Reviewed-on: https://code.wireshark.org/review/36706
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9bd47b7   dot11decrypt: Fix a resource leak on error path
     add  e4bfd8b   dot11decrypt: Silent Coverity Scan out-of-bounds access error


Summary of changes:
 epan/crypt/dot11decrypt_ccmp_compat.c | 2 +-
 epan/crypt/dot11decrypt_util.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)