Wireshark-commits: [Wireshark-commits] master 3662a69: Maintain cf->state, because file cleanup dep

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2020 20:59:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3662a69036f33a169301cfc76bd3a3c09023a68d
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3662a69 by Guy Harris (guy@xxxxxxxxxxxx):

    Maintain cf->state, because file cleanup depends on it.
    
    If we're capturing to multiple files, whenever we are told about a new
    file, we must close the old file, so we don't leak file descriptors and
    wtap structures.
    
    Have cf_close() handle the work of closing, the way it does in file.c,
    and, when we *open* a file, set the state in capture_file to
    FILE_READ_IN_PROGRESS.
    
    Bug: 16457
    Change-Id: I04a01c30571b7e3575dee5e7252a59bb1ee8abbc
    Reviewed-on: https://code.wireshark.org/review/36580
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  439005c   rlcmac: Introduce MS Radio Access Capabilities 2 to fix related spare bits
     add  3662a69   Maintain cf->state, because file cleanup depends on it.


Summary of changes:
 tshark.c | 37 ++++++++++++++++++++++---------------
 1 file changed, 22 insertions(+), 15 deletions(-)