Wireshark-commits: [Wireshark-commits] master badbc3c: rlcmac: Don't pass array element to CSN1 des

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2020 17:18:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=badbc3c6097e3365151eb97e94ee7f2d945ec094
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

badbc3c by Pau Espin Pedrol (pespin@xxxxxxxxxxx):

    rlcmac: Don't pass array element to CSN1 descriptors
    
    This way the macros can be used to access the arrays themselves and
    calculate its static size to enable validation lateri on.
    
    In the case of Packet_Access_Reject_t, modify the description to use a
    M_REC_TARRAY_1 object to get rid of access to 2nd element. The new
    description is the correct one, since the first element is mandatory
    according to TS 44.060 Table 11.2.1.
    
    Port from osmo-pcu.git 81b40cbaf3070f70954663f68375100128bdc77e.
    
    Change-Id: I48fc257305af799beb6a48ffc6d11b73026bff51
    Reviewed-on: https://code.wireshark.org/review/36571
    Reviewed-by: Harald Welte <laforge@xxxxxxxxxxxx>
    Reviewed-by: Vadim Yanitskiy <axilirator@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  f6ef53e   csn1: Validate recursive array max size during decoding
     add  badbc3c   rlcmac: Don't pass array element to CSN1 descriptors


Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)