Wireshark-commits: [Wireshark-commits] master 31f9331: TPNCP: Use security_cmd_offset value

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2020 14:00:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31f933121b192119662a48b7eb4c8991f2432278
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

31f9331 by Orgad Shaneh (orgad.shaneh@xxxxxxxxxxxxxx):

    TPNCP: Use security_cmd_offset value
    
    The layout of OpenSecureChannel command is:
    struct acTOpenSecureChannelSendCmd
    {
        int CID;
        struct acTOpenChannelCmd OpenChannelCmd;
        struct acTOpenSecureChannelCmd SecureChannelCmd;
    };
    
    OpenChannelCmd contains a field that stores the offset of
    SecureChannelCmd (rtp_authentication_algorithm) from the beginning of
    OpenChannelCmd (cmd_rev_lsb).
    
    Support both forward and backward compatibility (added or missing fields).
    
    Change-Id: If277996aa7fb94fef55ae34fed5a307728ebdf7c
    Reviewed-on: https://code.wireshark.org/review/36566
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a71765a   TPNCP: Simplify names for data field info
     add  31f9331   TPNCP: Use security_cmd_offset value


Summary of changes:
 epan/dissectors/packet-tpncp.c | 85 +++++++++++++++++++++++++++++++-----------
 1 file changed, 64 insertions(+), 21 deletions(-)