URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f19397ad434383d6b4332fbcbd2c2c1593516e0
Submitter: "Tomasz Moń <desowin@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
4f19397 by Tomasz Moń (desowin@xxxxxxxxx):
Qt: Improve tcptrace graph drag responsiveness
Subclass QCPErrorBars with implementation that never accepts clicks.
This prevents a lot of square root computations in QCustomPlot
mousePressEvent handle and results in usable tcptrace graph.
An alternative solution to the poor performance problem could be using
QCP::srmCustom SelectionRectMode. I don't know how to implement graph
drag with QCP::srmCustom, and thus I went with simple subclass approach.
Bug: 16281
Change-Id: Id4178e59bdbd2222db4669d0635ff741ebde839f
Reviewed-on: https://code.wireshark.org/review/36413
Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit eb7774e4c12e636c47049fdb1add80507311d2a2)
Reviewed-on: https://code.wireshark.org/review/36450
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
Actions performed:
from 4cb8ce5 Qt: Add elements back to the tcptrace graph.
add 4f19397 Qt: Improve tcptrace graph drag responsiveness
Summary of changes:
ui/qt/tcp_stream_dialog.cpp | 23 ++++++++++++++++++++---
ui/qt/tcp_stream_dialog.h | 12 ++++++++++++
2 files changed, 32 insertions(+), 3 deletions(-)