Wireshark-commits: [Wireshark-commits] master 14bc684: dot11decrypt: Use libgcrypt's CCMP decryptio

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Mar 2020 06:53:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14bc684b18e775b9a18aef8c095bc2aaf1e8f877
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

14bc684 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Use libgcrypt's CCMP decryption ability
    
    Simplify the CCMP decryption implementation by letting libgcrypt
    handle decryption, authentication and integrity check. This aims
    to simplify the implementation in preparation for CCMP-256
    decryption support where changes to the CCMP decryption implementation
    is anyway needed.
    
    Even though performance optimization was not the target for this
    change it appears decryption speed is improved as well.
    
    Change-Id: I6c36315291672f6313c9303ab8e50afb87aea9ce
    Reviewed-on: https://code.wireshark.org/review/36343
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a51e150   packet-ntlmssp: display the authentication key origin as expert info
     add  14bc684   dot11decrypt: Use libgcrypt's CCMP decryption ability


Summary of changes:
 epan/crypt/CMakeLists.txt                          |  12 +-
 epan/crypt/dot11decrypt_ccmp.c                     | 277 ++++++++-------------
 ...11decrypt_ccmp.c => dot11decrypt_ccmp_compat.c} |  51 ++--
 epan/crypt/dot11decrypt_int.h                      |  18 ++
 epan/crypt/dot11decrypt_rijndael.h                 |  12 -
 epan/crypt/dot11decrypt_system.h                   |  12 +-
 6 files changed, 165 insertions(+), 217 deletions(-)
 copy epan/crypt/{dot11decrypt_ccmp.c => dot11decrypt_ccmp_compat.c} (85%)