URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f8de1fcddb1ef452a3f5429bff69cd1976d20e07
Submitter: "Tomasz Moń <desowin@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
f8de1fc by Filipe Laíns (lains@xxxxxxxxxxxxx):
USB HID: make the dissection tree look as in the spec
Currently, the top dissection tree looks like this:
Global item (Usage Page)
Local item (Usage)
Main item (Collection)
This approach is not great: it provides little relevant information. The
item type (Main,Global,Local) is most of the time not relevant, it is
used to differentiate items within the spec and is not useful to the end
user. The item name (Usage Page, Usage, Collection, etc.) and its value
is much more relevant to the end user. We show the name, which is great,
but we don't show the value, forcing the user to open the subtree to
access it.
The report descriptors described in the spec are annotated like this:
Usage Page (Generic Desktop)
Usage (Mouse)
Collection (Application)
This patch makes the dissection tree look like that. All the information
is still present in the tree but we put the information most people are
actually interested in in the top level item.
Change-Id: Idbfb0f137bc82b5e69787ee524585d18eb697340
Signed-off-by: Filipe Laíns <lains@xxxxxxxxxxxxx>
Reviewed-on: https://code.wireshark.org/review/36374
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
Actions performed:
from 9f6fad0 WSUG: Update the I/O Graphs section.
add f8de1fc USB HID: make the dissection tree look as in the spec
Summary of changes:
epan/dissectors/packet-usb-hid.c | 95 +++++++++++++++++++++++++++++-----------
1 file changed, 70 insertions(+), 25 deletions(-)