Wireshark-commits: [Wireshark-commits] master 04a86e9: Qt: Fix import profile from directory crash

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 01 Mar 2020 06:48:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=04a86e99e46d680a50e78340ea6c7d16349f370a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

04a86e9 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Fix import profile from directory crash
    
    Do not append separator to import directory path. Calling QFileInfo()
    constructor with string ending in directory separator results in
    creating QFileInfo instance for file with empty filename.
    
    Bug: 16410
    Change-Id: I4fe248fcdb0c0c67843652475ae58c2a473a9fa8
    Reviewed-on: https://code.wireshark.org/review/36238
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  50a4063   USB: Record bcdVersion in device product data
     add  04a86e9   Qt: Fix import profile from directory crash


Summary of changes:
 ui/qt/profile_dialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)