Wireshark-commits: [Wireshark-commits] master 2c4fc32: smpp: Set the column fence before dissecting

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2020 07:44:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c4fc329130133965609da5337b6cdc107d7f3b1
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2c4fc32 by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    smpp: Set the column fence before dissecting the PDU
    
    Set the fence before dissecting the PDU because if the PDU is invalid it
    may throw an exception and the next PDU will clear the info about the
    current PDU.
    
    Change-Id: Ib8ad2e6e5b99c53fc75a8e55e86375a3cead1678
    Reviewed-on: https://code.wireshark.org/review/36131
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c86e995   FTDI MPSSE: Improve command descriptions
     add  2c4fc32   smpp: Set the column fence before dissecting the PDU


Summary of changes:
 epan/dissectors/packet-smpp.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)