URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7f53d94e7c93b66283286ed765f02a22d91930a4
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
7f53d94 by Guy Harris (guy@xxxxxxxxxxxx):
Use "must" instead of "should" to avoid ambiguity.
As I said in
https://ask.wireshark.org/question/10361/how-to-properly-use-heuristic-dissector-for-tcp/?answer=10363#post-id-10363
"Should" has multiple meanings; there's "Used to indicate obligation,
duty, or correctness, typically when criticizing someone's actions.", as
in "I think we should trust our people more", and there's "Used to
indicate what is probable.", as in "the bus should arrive in a few
minutes". You're reading it in the latter sense; it was intended in the
former sense.
That sentence should probably be changed to "Wireshark must be then set
up..." to avoid the ambiguity.
Make it so (over half a year later, sigh), and change another case where
"should" is meant in the first sense while we're at it.
Change-Id: I90198d1616619c75802deeeb703ceee0c8bac1bf
Reviewed-on: https://code.wireshark.org/review/36155
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit 05c1983ee85e760b8b38ee6da477d10ce95dba6c)
Reviewed-on: https://code.wireshark.org/review/36156
Actions performed:
from 9df1f61 Test: Bump the WireGuard Gcrypt version requirement.
add 7f53d94 Use "must" instead of "should" to avoid ambiguity.
Summary of changes:
doc/README.heuristic | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)