Wireshark-commits: [Wireshark-commits] master 22e617d: mptcp: correctly parse v1 ADD_ADDR suboption

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Feb 2020 06:26:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22e617d8623614a42974f7a714840ed80199b3e0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

22e617d by Peter Krystad (peter.krystad@xxxxxxxxxxxxxxx):

    mptcp: correctly parse v1 ADD_ADDR suboption
    
    RFC6824bis-18 (MPTCP version 1) removes the IP version field and
    replaces it with an Echo bit that provides a reliability
    mechanism for the ADD_ADDR option. This change allows either
    v0 or v1 ADD_ADDR options to be displayed correctly.
    
    Change-Id: I375bcf6e54c07f88ca8877a2c4b4220cf4157a64
    Reviewed-on: https://code.wireshark.org/review/36095
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c544f7e   Qt: initialize members (CID: 1457926).
     add  22e617d   mptcp: correctly parse v1 ADD_ADDR suboption


Summary of changes:
 epan/dissectors/packet-tcp.c | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)