Wireshark-commits: [Wireshark-commits] master 7646295: SDP: clarify that the G722 sample rate is ac

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Feb 2020 00:42:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76462953a9079c886e37a0dabebfbeaf04776feb
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7646295 by Peter Wu (peter@xxxxxxxxxxxxx):

    SDP: clarify that the G722 sample rate is actually 16000
    
    The actual sampling rate in plugins/codecs/G722/G722decode.c is reported
    as 16000 while the RTP clock rate as included in the SDP message is 8000
    for historical reasons. Add some text to help people understand where
    this difference comes from.
    
    Example dissection for this cosmetic change:
    
        Session Description Protocol
            ...
            Media Attribute (a): rtpmap:9 G722/8000
                Media Attribute Fieldname: rtpmap
                Media Format: 9
                MIME Type: G722
                Sample Rate: 8000 (RTP clock rate is 8kHz, actual sampling rate is 16kHz)
            Media Attribute (a): rtpmap:101 telephone-event/8000
                Media Attribute Fieldname: rtpmap
                Media Format: 101
                MIME Type: telephone-event
                Sample Rate: 8000
    
    Change-Id: I47ccb798719a23713f28ae36fff6716b6dfbb22b
    Reviewed-on: https://code.wireshark.org/review/36073
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  980cf9c   dcm(.h): Update DICOM 2020a definitions
     add  7646295   SDP: clarify that the G722 sample rate is actually 16000


Summary of changes:
 epan/dissectors/packet-sdp.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)