Wireshark-commits: [Wireshark-commits] master-3.2 1b6c8a2: ISAKMP: Critical flag should not be in p

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 05 Feb 2020 04:36:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b6c8a29caf6c2ad6db7ec5a57110b8f34cfc2af
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

1b6c8a2 by Dr. Lars Völker (lars.voelker@xxxxxxxxxxxxxxxxxxxxxxx):

    ISAKMP: Critical flag should not be in proposals and transforms
    
    IKEv2 added the critical flag to all payloads except payloads and
    transforms. The dissection code just checked that it was looking at
    IKEv1 but missed a check for proposals and transforms.
    
    Bug: 16364
    Change-Id: Ia9297af039fddf2da81f9712fdf7ac165fb2d86d
    Signed-off-by: Dr. Lars Völker <lars.voelker@xxxxxxxxxxxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36009
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 8c9efa5f1bc1f57b4293ea39b76c91548dc45121)
    Reviewed-on: https://code.wireshark.org/review/36013
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fd0e8bc   Qt: simplify decode_as_ action in the packet details view
     add  1b6c8a2   ISAKMP: Critical flag should not be in proposals and transforms


Summary of changes:
 epan/dissectors/packet-isakmp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)