Wireshark-commits: [Wireshark-commits] master 8c9efa5: ISAKMP: Critical flag should not be in propo

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 03 Feb 2020 07:27:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c9efa5f1bc1f57b4293ea39b76c91548dc45121
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8c9efa5 by Dr. Lars Völker (lars.voelker@xxxxxxxxxxxxxxxxxxxxxxx):

    ISAKMP: Critical flag should not be in proposals and transforms
    
    IKEv2 added the critical flag to all payloads except payloads and
    transforms. The dissection code just checked that it was looking at
    IKEv1 but missed a check for proposals and transforms.
    
    Bug: 16364
    Change-Id: Ia9297af039fddf2da81f9712fdf7ac165fb2d86d
    Signed-off-by: Dr. Lars Völker <lars.voelker@xxxxxxxxxxxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36009
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b5c629b   tools: add lua to bsd-setup.sh.
     add  8c9efa5   ISAKMP: Critical flag should not be in proposals and transforms


Summary of changes:
 epan/dissectors/packet-isakmp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)