Wireshark-commits: [Wireshark-commits] master 59108b1: Qt: replace QRegExp with QRegularExpression

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Jan 2020 19:33:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59108b16835707dee35680d5951ffa1b4fd49b9e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

59108b1 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: replace QRegExp with QRegularExpression in FilterListModel.
    
    The new class has a more powerful support for non-greedy regexps
    (required in this case).
    
    See: https://doc.qt.io/qt-5/qregularexpression.html#notes-for-qregexp-users
    
    Bug: 16336
    Change-Id: I4684fbf6aeeb55707d325775de487246ac398c2d
    Reviewed-on: https://code.wireshark.org/review/35858
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  17a6916   epan/to_str: change MAX_BYTE_STR_LEN from 48 to 72
     add  59108b1   Qt: replace QRegExp with QRegularExpression in FilterListModel.


Summary of changes:
 ui/qt/models/filter_list_model.cpp | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)