Wireshark-commits: [Wireshark-commits] master 82ed891: mp4: factor out FullBox dissection

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Jan 2020 19:26:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82ed8918ab25f45254092e32e12d12234ab6d939
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

82ed891 by Jakub Adam (jakub.adam@xxxxxxxxxxxxx):

    mp4: factor out FullBox dissection
    
    Avoid repeating code dealing with dissection of version and flags fields
    that ISO/IEC 14496-12 defines in FullBox class.
    
    Change-Id: I72cb4072c8bb41a670d41187692dd72697dd1049
    Reviewed-on: https://code.wireshark.org/review/35888
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  41be9b9   mp4: tkhd times are encoded as ENC_TIME_CLASSIC_MAC_OS_SECS
     add  82ed891   mp4: factor out FullBox dissection


Summary of changes:
 epan/dissectors/file-mp4.c | 100 ++++++++++++++++++++-------------------------
 1 file changed, 44 insertions(+), 56 deletions(-)