Wireshark-commits: [Wireshark-commits] master 75e1b69: CoAP: change detection logic for CoAP over T

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 21 Jan 2020 22:09:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75e1b69e88bb6856bbae443aa64efdceb3e39117
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

75e1b69 by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    CoAP: change detection logic for CoAP over TCP or TLS
    
    Do not assume that having a TCP port means that CoAP is running directly
    over TCP: this is not the case with MQTT for example (see bug 14591 for
    a capture). Instead explicitly check that the parent dissector is TCP or
    TLS.
    
    Bug: 15910
    Change-Id: Ib4880623b8525fe6be52a685397005eac86da135
    Reviewed-on: https://code.wireshark.org/review/35879
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  3442c76   Windows: fix win32 libilbc package
     add  75e1b69   CoAP: change detection logic for CoAP over TCP or TLS


Summary of changes:
 epan/dissectors/packet-coap.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)