URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0db02a89f3cb0bca3a8c6a796e7bd8822e4b3c3f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
0db02a8 by Vadim Yanitskiy (axilirator@xxxxxxxxx):
GSUP/SMS: also dissect ToN/NPI header in SM-RP-DA/OA
Unlike IMSI, both MSISDN and SMSC Address in SM-RP-OA/DA not only
contain the BCD encoded digits, but also a little header with
NPI (Numbering Plan Identification), ToN (Type of Number), and
Extension fields.
IE: SM-RP-DA (Destination Address)
Information Element Identifier: SM-RP-DA (Destination Address) (65)
Information Element Length: 8
Address Type: SMSC Address (3)
1... .... = Extension: No Extension
.001 .... = Nature of number: International Number (0x1)
.... 0001 = Number plan: ISDN/Telephony Numbering (Rec ITU-T E.164) (0x1)
E.164 number (MSISDN): 447785016005
Country Code: United Kingdom of Great Britain and Northern Ireland (44)
Let's dissect that header and following address bytes using the
public API from MAP dissector - dissect_gsm_map_msisdn().
Change-Id: Idc8a098926d38770002ba689efcf2c794c6b18d9
Reviewed-on: https://code.wireshark.org/review/35664
Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 1fec433 DCERPC: display various driver version fields as hex
add 0db02a8 GSUP/SMS: also dissect ToN/NPI header in SM-RP-DA/OA
Summary of changes:
epan/dissectors/packet-gsm_gsup.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)