URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=088266e39eb55a94720150ce234b6224e6e88325
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
088266e by Jaap Keuter (jaap.keuter@xxxxxxxxx):
Netlink: stop hiding packet_netlink_data pointer
The underlying netlink dissector sets up a data structure to help maintain
information about this netlink packet. It gets passed through the familiy
specific netlink dissectors private data structures to reappear when
support funtions of the underlying netlink dissector are needed. In the
mean time a copy of data (the value 'encoding' to be precise) in this
structure is also maintained in these familiy specific netlink dissectors,
adding to the confusion.
This change is to make the underlying netlink dissector data structure
a normal part of the function interfaces, so that it is present without
being dependant on another private data structure.
This change is a first step towards removing the unnessesary copy of the
encoding value.
Change-Id: I69e78a2b15e58e149e82e89c19e519ef041ee6b1
Reviewed-on: https://code.wireshark.org/review/35688
Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 200124d NSIS: Make the licensing page match reality.
add 088266e Netlink: stop hiding packet_netlink_data pointer
Summary of changes:
epan/dissectors/packet-netlink-generic.c | 38 ++++-----
epan/dissectors/packet-netlink-net_dm.c | 26 +++---
epan/dissectors/packet-netlink-netfilter.c | 126 ++++++++++++++---------------
epan/dissectors/packet-netlink-nl80211.c | 66 +++++++--------
epan/dissectors/packet-netlink-route.c | 69 ++++++++--------
epan/dissectors/packet-netlink-sock_diag.c | 114 +++++++++++++-------------
epan/dissectors/packet-netlink.c | 14 ++--
epan/dissectors/packet-netlink.h | 21 ++++-
8 files changed, 244 insertions(+), 230 deletions(-)