Wireshark-commits: [Wireshark-commits] master e901403: HTTP: Fix dissection of data following the H

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Dec 2019 17:24:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e9014030fe2dc5926a7e7e8d9f29bf1ebcf6b6bd
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e901403 by Peter Wu (peter@xxxxxxxxxxxxx):

    HTTP: Fix dissection of data following the HTTP Upgrade response
    
    When a HTTP response includes HTTP headers and a subset of data for the
    subdissector in the same frame, be sure to skip the HTTP headers for
    reassembly of the latter data. Otherwise the HTTP headers will be
    misinterpreted as the subprotocol (for example, WebSocket).
    
    Bug: 16274
    Change-Id: Ida6f6f2f7d0c463be2d498bfde5e8a9cd11a4b25
    Reviewed-on: https://code.wireshark.org/review/35536
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  f8aa0d5   LPP: upgrade dissector to 37.355 v15.0.0
     add  e901403   HTTP: Fix dissection of data following the HTTP Upgrade response


Summary of changes:
 epan/dissectors/packet-http.c | 7 +++++++
 1 file changed, 7 insertions(+)