Wireshark-commits: [Wireshark-commits] master 1c98b5b: log3gpp: invert check with use of offset.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Dec 2019 18:57:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c98b5b1800416460014b4dd6cdd4bba2d9c5a52
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1c98b5b by Dario Lombardo (lomato@xxxxxxxxx):

    log3gpp: invert check with use of offset.
    
    n is used to address the buffers, but the check condition
    follows its use. Fix the code by inverting the two of them
    
    Bug: 16283
    Change-Id: I7cba868979982946f99cfe787a7b5f86d2db1b70
    Reviewed-on: https://code.wireshark.org/review/35538
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a8331a9   802.11: Use the pseudo-header PHY to determine whether it's DMG.
     add  1c98b5b   log3gpp: invert check with use of offset.


Summary of changes:
 wiretap/log3gpp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)